emateli updated this revision to Diff 44189. emateli added a comment.
- use _p notation. Add BatchRenameDialog to installable headers --- Besides any current review, the last step for this patch would be to actually use the BatchRenameJob already in KIO. Regarding that: Should I put it into a separate patch and make this depend on it or continue working here? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14631?vs=42324&id=44189 BRANCH batchrename2 REVISION DETAIL https://phabricator.kde.org/D14631 AFFECTED FILES autotests/CMakeLists.txt autotests/batchrenametypestest.cpp autotests/batchrenametypestest.h src/widgets/CMakeLists.txt src/widgets/rename/batchrenamedialog.cpp src/widgets/rename/batchrenamedialog.h src/widgets/rename/batchrenamedialogmodel_p.cpp src/widgets/rename/batchrenamedialogmodel_p.h src/widgets/rename/batchrenametypes_p.cpp src/widgets/rename/batchrenametypes_p.h src/widgets/rename/batchrenamevar_p.cpp src/widgets/rename/batchrenamevar_p.h src/widgets/rename/filenameutils_p.cpp src/widgets/rename/filenameutils_p.h tests/CMakeLists.txt tests/batchrenamedialogtest_gui.cpp To: emateli, #frameworks, dfaure Cc: asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
