bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS
> poboiko wrote in app.cpp:74 > I haven't work with `QDataStream` before, but shouldn't `m_inputStream >> > nIds` do the same? (and same below) > And probably you should avoid magical constants (4, 8, etc) - better use > corresponding `sizeof`s readRawData consumes N bytes, while operator>> consumes N + sizeof(serialization meta data). I don't care to much for this code, as it is removed in the followup patch. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16523 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
