astippich added inline comments. INLINE COMMENTS
> xmlextractor.cpp:24 > + > +#include <QDebug> > +#include <QDomDocument> seems unused > xmlextractor.cpp:27 > +#include <QFile> > +#include <QXmlStreamReader> > + same > xmlextractor.cpp:71 > + > + return list; > +} Can we agree on using a static qstringlist if the mimetypes are fixed? I prepared a patch to convert all other extractors to this scheme when applicable in D16554 <https://phabricator.kde.org/D16554> Also, using an initializer list is faster, see https://www.angrycane.com.br/en/2018/06/19/speeding-up-cornercases/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16489 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
