astippich added inline comments.
INLINE COMMENTS
> extractorcollection.cpp:163
> + if (!plugins.isEmpty()) {
> + qCDebug(KFILEMETADATA_LOG) << "Using inherited mimetype" <<
> ancestor << "for" << mimetype;
> + return plugins;
nitpick: extra space before "for"
> extractorcollection.cpp:164
> + qCDebug(KFILEMETADATA_LOG) << "Using inherited mimetype" <<
> ancestor << "for" << mimetype;
> + return plugins;
> }
doesn't returning here cause immediate return after the first matching
extractor for the mimetype has been found? that doesn't fit to the first
paragraph of the summary.
"Otherwise, all matches for all mime ancestors are returned, even if one plugin
is a much better match than any other." sounds to me that all plugins of all
ancestors are returned.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16593
To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
