ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
This fails the symlink test: $ (arcpatch-D16588) make test Running tests... Test project /home/dev/repos/breeze-icons Start 1: appstreamtest 1/5 Test #1: appstreamtest .................... Passed 0.56 sec Start 2: symlink 2/5 Test #2: symlink ..........................***Failed 0.23 sec Start 3: newline 3/5 Test #3: newline .......................... Passed 0.11 sec Start 4: dupe 4/5 Test #4: dupe .............................***Failed 0.01 sec Start 5: scalable 5/5 Test #5: scalable .........................***Failed 0.03 sec 2/5 Testing: symlink 2/5 Test: symlink Command: "/home/dev/repos/breeze-icons/bin/symlink" Directory: /home/dev/repos/breeze-icons/autotests "symlink" start time: Nov 02 16:29 MDT Output: ---------------------------------------------------------- ********* Start testing of SymlinkTest ********* Config: Using QtTest library 5.11.2, Qt 5.11.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.3.0) PASS : SymlinkTest::initTestCase() FAIL! : SymlinkTest::test_broken() Found broken symlinks: /home/dev/repos/breeze-icons/icons-dark/actions/16/unrequired.svg => /home/dev/repos/breeze-icons/icons-dark/actions/16/package-install.svg Please fix. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg, ngraham Cc: valorie, bruns, ngraham, #vdg, kde-frameworks-devel, michaelh