broulik added a comment.

  The header file for `class Permeability` should probably be named 
`permeability_p.h` to match the other category classes since it's a not 
exported implementation detail

INLINE COMMENTS

> unit.h:335
> +    /** @since 5.53 */
> +    Darcy,
> +    /** @since 5.53 */

Given this is a new category, assign `Darcy = 33000` so that one can still add 
new values after `Yoctoohm` to electrical resistance category without breaking 
compatibility

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

Reply via email to