sredman added a comment.

  This is going to be our cleanest patch ever once we've had everybody and 
their grandmother look at it. I guess this is what happens when you fix a hot 
bug! 🙂
  
  In D16692#354783 <https://phabricator.kde.org/D16692#354783>, @jriddell wrote:
  
  > I can recreate the problem with 1.3 branch build of kdeconnect-kde in a 
virtualmachine install of KDE neon user edition
  >  The problem remains when building and installing it with the D16692 
<https://phabricator.kde.org/D16692> patch
  >
  > Building 1.3 branch on KDE neon developer edition I can not recreate the 
problem.  So the problem may be in some other area such as kio framework.
  
  
  On my KDE Neon user edition VM, this patch solves the issue 😬

INLINE COMMENTS

> CMakeLists.txt:23
> +install(TARGETS kio_kdeconnect DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/kio)
> +#install(FILES kdeconnect.protocol DESTINATION ${SERVICES_INSTALL_DIR})

Is there some reason to keep this line as a comment?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

Reply via email to