bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > exiv2extractor.cpp:285 > + if (it != data.end()) { > + alt = it->value().toFloat(); > + it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef")); According to: https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html and http://www.cipa.jp/std/documents/e/DC-008-Translation-2016-E.pdf the absolute altitude value is a rational, like deg/min/sec. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams