ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
A surprisingly small amount of code for a nice feature. Code looks good to me
except for one minor thing. This works great in my testing now. I say let's
ship it, especially because it won't result in any UI changes at all for people
who don't use tags.
INLINE COMMENTS
> kfileplacesmodel.cpp:187
> + while (!bookmark.isNull()) {
> + QUrl url = bookmark.url();
> +
const. But in fact, does this even need to be a variable? It's only used once.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D7700
REVISION DETAIL
https://phabricator.kde.org/D7700
To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham
Cc: kde-frameworks-devel, bruns, rkflx, mmustac, spoorun, michaelh, renatoo,
anthonyfieroni, cfeck, elvisangelaccio, emmanuelp, ngraham, alexeymin,
#dolphin, alexde, sourabhboss, feverfew, navarromorales, firef, andrebarros,
mikesomov
