poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land.
Apart from trivial comment, this looks fine. I've tested it on my setup (with bunch of (e)ps files), and randomly chosen files seems to be indexed nicely. It also reduced the size of the index by almost 50MB, because those are not indexed as plaintext anymore :) Yet I would also vote for replacing it (eventually) with a full-featured extractor based on libspectre (I'm not a security specialist in any way, but that CVE doesn't look too harmful, and from my point of view it's not worth to abandon full support of (E)PS because of it) INLINE COMMENTS > postscriptdscextractortest.cpp:27 > +#include <QTest> > +#include <QDir> > + This, and QDebug, seems to be not used anymore. REPOSITORY R286 KFileMetaData BRANCH postscript_dsc REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
