acrouthamel added a comment.
I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Do I need to run this test on a new user account or something? FAIL! : PlacesItemModelTest::testDeletePlace() Compared lists differ at index 2. Actual (places): "/home/andrew/Desktop" Expected (urls): "/home/andrew/Documents" Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(411)] FAIL! : PlacesItemModelTest::testPlaceItem(Places - Home) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testPlaceItem(Baloo - Documents) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testPlaceItem(Baloo - Today) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testPlaceItem(Devices - Floppy) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testTearDownDevice() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testDefaultViewProperties(Places - Home) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testDefaultViewProperties(Baloo - Documents) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testDefaultViewProperties(Places - Audio) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testDefaultViewProperties(Baloo - Today) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testDefaultViewProperties(Devices - Floppy) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testClear() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testHideItem() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testSystemItems() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testEditBookmark() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testEditAfterCreation() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testEditMetadata() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testRefresh() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testIcons(Places - Home) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testIcons(Baloo - Documents) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testIcons(Baloo - Today) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testIcons(Devices - Floppy) Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testDragAndDrop() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testHideDevices() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::testDuplicatedEntries() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] FAIL! : PlacesItemModelTest::renameAfterCreation() Compared values are not the same Actual (m_model->count()) : 19 Expected (m_expectedModelCount): 18 Loc: [/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)] REPOSITORY R241 KIO BRANCH add-documents (branched from master) REVISION DETAIL https://phabricator.kde.org/D16852 To: acrouthamel, #frameworks, #dolphin, ngraham Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns