davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision.
REVISION SUMMARY Somehow in the kdelibs -> framework port the cmake checks for HAVE_SENDFILE got lost. That removes a massive optimisation in the file kioslave that we're skipping seemingly accidentally. TEST PLAN Put a compilation fail inside the #ifdef, before it wasn't triggered, now it is. Ran unit tests Moved a file in dolphin REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17048 AFFECTED FILES src/ioslaves/file/ConfigureChecks.cmake src/ioslaves/file/config-kioslave-file.h.cmake To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns