sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
${PHONON_LIBS} as the name suggests links all libraries, that includes
the experimental library. it's not even used though.
move to imported target to avoid linking experimental and also get rid
of the include_directories call
TEST PLAN
➜ DESTDIR=x ninja install &> /dev/null; grep -ri phonon4qt5experimental x
x/usr/lib/x86_64-linux-gnu/cmake/KF5NotifyConfig/KF5NotifyConfigTargets-debug.cmake:
IMPORTED_LINK_DEPENDENT_LIBRARIES_DEBUG
"KF5::I18n;KF5::KIOWidgets;Phonon::phonon4qt5;Phonon::phonon4qt5experimental;Qt5::DBus"
with new code
`
➜ DESTDIR=x ninja install &> /dev/null; grep -ri phonon4qt5experimental x
REPOSITORY
R305 KNotifyConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17234
AFFECTED FILES
src/CMakeLists.txt
To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
