cgiboudeaux added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in FindPhoneNumber.cmake:85
> phonenumber doesn't install a pkg-config file, this variable is empty

Note: this is harmless, but maybe just add

  set(PhoneNumber_VERSION 0)

to make it clear. AFAICS, none of the public headers contain the library version

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16954

To: vkrause, #build_system, #frameworks
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

Reply via email to