jgrulich added inline comments. INLINE COMMENTS
> tcsettingtest.cpp:92 > + if (comparedvals == map.size()) { > + comparedMaps++; > + } You still don't compare the values. > jgrulich wrote in setting.cpp:33 > Same here, should be NM 1.14.0. NM 1.14.0 is needed for NM_SETTING_MATCH_SETTING_NAME > jgrulich wrote in tcsetting.cpp:118 > Indent. Still applies. > jgrulich wrote in tcsetting.cpp:122 > const QVariantMap &tfilter Still applies. > tcsetting.h:27 > + > +#include <QString> > +#include <QStringList> No need to include QString and QStringList REVISION DETAIL https://phabricator.kde.org/D17317 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns