jgrulich added inline comments. INLINE COMMENTS
> teamportsettingtest.cpp:100 > + > + QVariantMap::const_iterator it_1 = map.constBegin(); > + while (it_1 != map.constEnd()) { This is again wrong, you want to go through "link-watchers" map, not through the whole map. > teamportsettingtest.cpp:117 > + if (val1 != varMap1.constEnd()) { > + if (varMap.value(ite.key()) == val1.value()) { > + ++comparedvals; I think you can use QCOMPARE() here, to make it fail in case they don't match. REVISION DETAIL https://phabricator.kde.org/D17342 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns