emateli updated this revision to Diff 47694. emateli added a comment.
- convert to namespace from class - do not show first captured group - remove help button - Use d-ptr pattern - remove show/hide methods and autoshow dialog - update doc - KFileItemList -> QList<QUrl>; KFileItem usage was unnecessary - update doc - WIP Change BatchRenameJobPrivate class This is still a WIP mostly with the use of d-ptr pattern for the exported header and the conversion of BatchRenameJob from a class with a very specific purpose to a general-purpose batch rename operation. Looking for comments especially for the repurposing of the BatchRenameJob class(currently used only by Doplhin) and other thoughts in general as well. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14631?vs=45438&id=47694 BRANCH batchrename2 REVISION DETAIL https://phabricator.kde.org/D14631 AFFECTED FILES autotests/CMakeLists.txt autotests/batchrenametypestest.cpp autotests/batchrenametypestest.h src/core/batchrenamejob.cpp src/core/batchrenamejob.h src/widgets/CMakeLists.txt src/widgets/rename/batchrenamedialog.cpp src/widgets/rename/batchrenamedialog.h src/widgets/rename/batchrenamedialogmodel.cpp src/widgets/rename/batchrenamedialogmodel_p.h src/widgets/rename/batchrenametypes.cpp src/widgets/rename/batchrenametypes_p.h src/widgets/rename/batchrenamevar.cpp src/widgets/rename/batchrenamevar_p.h src/widgets/rename/filenameutils.cpp src/widgets/rename/filenameutils_p.h tests/CMakeLists.txt tests/batchrenamedialogtest_gui.cpp tests/previewtest.cpp To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
