cochise added a comment.
In D17816#383421 <https://phabricator.kde.org/D17816#383421>, @davidedmundson wrote: > Why do we need the code in both CopyJob and File_unix? The code was initially put in file_unix, but testing I found it won't applies to directories, so I put on CopyJob, and found that it not applies to dirs renamed because of name conflicts. I plan to find the call points to tackle all the use cases and then refactor into a function, to avoid code duplication. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, bruns