cgiboudeaux added a comment.
In D17863#384229 <https://phabricator.kde.org/D17863#384229>, @tcberner wrote: > In D17863#384145 <https://phabricator.kde.org/D17863#384145>, @cgiboudeaux wrote: > > > Why not fixing kstars instead? > > > > > include(ECMCheckLinkerFlags) > [...] > # Check for nodump support > SET(NODUMP_FLAGS "-Wl,-z,nodump") > ecm_check_linker_flags("${NODUMP_FLAGS}" NODUMP_SUPPORTED) > if (NODUMP_SUPPORTED) > SET(SEC_LINK_FLAGS "${SEC_LINK_FLAGS} ${NODUMP_FLAGS}") > endif () > > > Of course kstars could also just stop adding nodump ever :) agreed, kstars should stop adding random flags and just use what ECM already provides. For this reason, -1 for having this in ECM. This is a workaround for an app issue (and is not unit tested) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
