dfaure added a comment.
Looks good. This assumes that no process exits cleanly (code 0) while not
showing anything to the user, but even if that happened, better no klauncher
error in that case, than an error in a normal case like the kate one.
INLINE COMMENTS
> klauncher.cpp:340
> + request->status = KLaunchRequest::Done;
> + qCDebug(KLAUNCHER) << pid << "died with exitStatus= 0,
> requestDone. status=" << request->status ;
> } else {
To make this less scary (since it's not an error) I would suggest
<< "exited without error, request done. status=" <<
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D18089
To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
