mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed.
can you please rephrase the title of this review to make it understandable? "Remove all" - what do you remove? All what? Also, can you please add tests for the feature you are adding, this also acts as documentation on what this patch actually does REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17128 To: loh.tar, #ktexteditor, cullmann, mwolff Cc: mwolff, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars
