loh.tar added subscribers: cullmann, dhaumann.
loh.tar added a comment.

  > please add proper tests for this functionality
  
  No idea how
  
  Because  there are a couple of bug reports where often the response was like 
"No, can't be done" need this a closer look from @dhaumann and @cullmann

INLINE COMMENTS

> mwolff wrote in kateview.cpp:2355
> store in a std::unique_ptr and remove the manual `delete` further down below

fine, will do it

> mwolff wrote in kateview.cpp:2359
> bool shouldWrap = true;

I dislike that. I hope someone else like my goto way

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17949

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

Reply via email to