mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kateprinter.cpp:164
> QPrinter printer;
> - KatePrinterPrivate p(view->doc(), view);
> + KatePrinterPrivate p(view->doc(), view, true);
> QPrintPreviewDialog preview(&printer);
better add a setter before and then call
`p.setColorScheme(QStringLiteral("Printing"));`
here
> kateprinter.cpp:180
> QPrinter printer;
> - KatePrinterPrivate p(doc);
> + KatePrinterPrivate p(doc, nullptr, true);
> QPrintPreviewDialog preview(&printer);
dito
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D18163
To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,
demsking, cullmann, sars, dhaumann
