elvisangelaccio added a comment.

  LGTM

INLINE COMMENTS

> CMakeLists.txt:265
> +
> +install(TARGETS ebookthumbnail DESTINATION ${PLUGIN_INSTALL_DIR})
> +

`PLUGIN_INSTALL_DIR` is deprecated, new code should use `KDE_INSTALL_PLUGINDIR`

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg
Cc: elvisangelaccio, abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

Reply via email to