ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
The default match mode tries both file extension and content <https://doc.qt.io/qt-5/qmimedatabase.html#MatchMode-enum>; this would make it just do content. So I guess if they don't match, the default match mode uses the file extension rather than content? That seems kinda like the opposite of the behavior you'd want; might be worth a Qt bug report and aldo a comment in the code here explaining why we're doing this. The change itself seems sane since we're actually doing less, more correct work now. What more is needed to fix 403902? REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18819 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
