broulik added inline comments.

INLINE COMMENTS

> pino wrote in pdfcreator.cpp:45-46
> please honor the requested width and height

I can't. The `renderToImage` can only be told a resolution or part of the page 
to render, to render downscaled into a certain box.

The `ThumbnailJob` downscales the image when it exceeds the requested size, so 
doing any manual downscaling (other than already getting the correct size which 
we can't) here is superfluous.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Reply via email to