apol added inline comments.

INLINE COMMENTS

> FindFontconfig.cmake:57
> +find_package(PkgConfig)
> +pkg_check_modules(PC_FONTCONFIG QUIET fontconfig)
> +

If you use IMPORTED_TARGET you can skip most stuff below. i.e.
`pkg_check_modules(Flatpak IMPORTED_TARGET flatpak>=0.11.8)`

In fact, I'd argue it's just easier to have pkg_check_modules called upstream 
rather than having an intermediary in ECM or so. 
It's what I did in Discover at least:
https://phabricator.kde.org/source/discover/browse/master/CMakeLists.txt$36

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

Reply via email to