cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed.
I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me. I would appreciate a comment what the "lang" param is and that "lang" is "language", we don't need to shorten that in the API. Code-wise: Could you not just use "find" on the d->languageClients and check the iterator? That way we avoid searching twice (in different data structures). REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18907 To: ahmadsamir, sandsmark, cullmann, dhaumann Cc: dhaumann, cullmann, loh.tar, kde-frameworks-devel, michaelh, ngraham, bruns
