astippich added a comment.
A few general remarks: - I really do not like that there are two lists of supported mimetypes now which have to be kept in sync - Do we really need versioning per mimetype? IMHO it is sufficient to have a version number per extractor. From my experience, fixing an extractor usually impacts all its supported mimetypes, and rarily affects only one mimetype. Also, this makes the list hard to maintain, also regarding file types which have multiple mime types, e.g. audio/wav and audio/x-wav - Do we need an x.y version? I think a single integer is enough or what do you have in mind? - I prefer to directly construct the qvariantmap in the extractors, and re-use the mimetype list which is already available. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
