cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land.
Thanks! just a little thing to fix before pushing INLINE COMMENTS > FindCanberra.cmake:75 > +find_package_handle_standard_args(Canberra > + REQUIRED_VARS > + Canberra_LIBRARIES Also add FOUND_VAR Canberra_FOUND The default for CMake 2.8.12 which ECM requires is '<UPPERCASED_NAME>_FOUND'. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns