bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > astippich wrote in formatstrings.cpp:157 > That was actually done deliberately to get this in for Kf 5.56 since there is > string freeze. But if concatenation is a no go, this has to wait Thats obviously just avoiding the rules. You can ask for an exception anyway. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_aspectratio REVISION DETAIL https://phabricator.kde.org/D19102 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams