dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ksycocathreadtest.cpp:306
>          now = QDateTime::currentDateTime();
> -        if (now.toTime_t() == ctime.toTime_t())   // truncate milliseconds
> +        if (now.toMSecsSinceEpoch() == ctime.toMSecsSinceEpoch())   // 
> truncate milliseconds
>          {

This doesn't truncate milliseconds anymore....

You should port toTime_t to toSecsSinceEpoch (no 'M')

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D19436

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to