dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
I see, that's because the old file isn't utf8, for the diff. Well, next time it'll work ;) INLINE COMMENTS > mlaurent wrote in kpluginmetadata.cpp:233 > people was const. So I thought that it was not necessary. > But I created it. people is const, but the method in QJsonValue is QJsonArray toArray() const; so the array isn't const. It almost sounds like it's suddenly useful to return const values.... weird, because std::move usage says otherwise. REPOSITORY R244 KCoreAddons BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19299 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
