ahmadsamir added a comment.
In D18793#424628 <https://phabricator.kde.org/D18793#424628>, @cullmann wrote: > I don't like the change to call typeChars. > > 1. that needs a valid view, activeView() might be null. > 2. replaceText is not interactive per-default, but typeChars is. > > And yes, a test would be wanted I think,too. OK, I'll try reworking it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, mwolff Cc: loh.tar, mwolff, kde-frameworks-devel, kwrite-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
