loh.tar updated this revision to Diff 53296. loh.tar retitled this revision from "DocumentPrivate: Auto reload in read-only mode" to "DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt". loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a comment.
- Add option "Enable Auto Reload" to ModOnHdPrompt - Allow also auto reload for not read-only files - Only auto reload when doc is unmodified - Only reload when no reload is in progress, may that not enough to avoid mentioned lock up? Issues: - The new button is slightly dangerous placed for my taste but with intend not nearby the normal reload button - No other way to disable that setting than to close/open the file - The reload is only triggered when the application has the focus, but that may be an intended behavior TODO(?) - Add getter function so that e.g. the status bar can show a suitable icon to indicate that mode and the ModOnHdPrompt can hide that button in case of an already active setting - Add some option/action to the view so that the view scrolls down after an auto reload CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19517?vs=53132&id=53296 REVISION DETAIL https://phabricator.kde.org/D19517 AFFECTED FILES src/dialogs/katedialogs.cpp src/dialogs/katedialogs.h src/document/katedocument.cpp src/document/katedocument.h To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
