hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision.
REVISION SUMMARY Reset m_request.isKeepAlive to true if responseCode == 301 during renaming a directory. Otherwise the connection is gone and renaming fails, if the server is configured 'KeepAlive off'. After sending the not quite correct request 'MOVE dirurl' without trailing '/', an Apache webserver answers with a redirection (301) providing the correct dirurl with trailing '/'. But in this case the session is not reset, so if the server sets isKeepAlive to false the connection is ended too early. TEST PLAN - Configure an Apache http server providing WebDAV and set KeepAlive to 'off'. - In dolphin, navigate to webdav://webdavserver/ and try to rename a directory there. - Without this patch the connection to webdavserver is broken (error message) and renaming fails, with this patch applied it works. REPOSITORY R241 KIO BRANCH fix_webdav_rename_directory REVISION DETAIL https://phabricator.kde.org/D19786 AFFECTED FILES src/ioslaves/http/http.cpp To: hoffmannrobert Cc: kde-frameworks-devel, michaelh, ngraham, bruns