cgiboudeaux added inline comments.

INLINE COMMENTS

> vkrause wrote in KDECMakeSettings.cmake:189
> Right, the feature is just silently ignored in older versions. We can 
> probably switch that to PythonIterp if we want this for older versions as 
> well. But let's first see if this approach actually works and if people will 
> access getting that test forced upon them :)

PythonInterp is also not a solution :) See 6c1db934e 
<https://phabricator.kde.org/R249:6c1db934e648620eeb0e5fc9468c5c2f2f9864b9> in 
ki18n.

CMake 3.5.0 was found acceptable for most frameworks, it would be nice to make 
it work with this version.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

Reply via email to