ivan marked an inline comment as done.
ivan added inline comments.

INLINE COMMENTS

> broulik wrote in previewjob.cpp:307
> Did you profile the impact of this call? I don't think it's cached. Can this 
> maybe be moved to the thumbnail KIO so it's done out of process?

I didn't do any profiling.

We can not cache because mount points can change. KMountPoint provides no 
signals of this.

It should not be overly expensive - small number of mounts to process.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to