dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > kcombobox.cpp:60 > > if (q->isEditable()) { > q->lineEdit()->setContextMenuPolicy(Qt::DefaultContextMenu); Are you sure the line shouldn't be moved under this if()? It wouldn't warn here, since that's the case where it's editable. At least this seems safer, unless you did the additional research of whether (or not) there is indeed a completer that we want to remove on editable comboboxes. REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D20016 To: elvisangelaccio, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns