astippich added inline comments. INLINE COMMENTS
> bruns wrote in propertyinfotest.cpp:97 > This will of course fail as soon as someone translates fps, e.g. german > "B/s", even more in RTL locales. > > Probably the better solution is to provide the whole string verbatim, and > mark it with i18n. Until then, tests should be run with an en or C locale. I do not want to start adding translations to unit tests, that seems over the top. I agree it's not perfect, but it is an easy way to catch at least some missing localizations. If you prefer, I can query startsWith(QLocale.toString()) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20012 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
