nibags updated this revision to Diff 55004. nibags marked an inline comment as done. nibags added a comment.
- Fix attributes in "KDE" and "Vim (dark)" themes I found a small bug in this patch. In the "KDE" and "Vim (dark)" schemas, hard colors and text backgrounds, defined in XML files, don't work. I have updated the diff: now, for these cases, an empty theme will be used and only the attributes defined in the XML files will be applied, such as `bold="1"` or `color="#CCCC"`. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19876?vs=54775&id=55004 BRANCH fix-schemas REVISION DETAIL https://phabricator.kde.org/D19876 AFFECTED FILES src/syntax/katehighlight.cpp src/syntax/katehighlight.h To: nibags, #ktexteditor, #kate, cullmann, mwolff Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, sars