bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision.
REVISION SUMMARY There is no guarantee the attribute size does not change between two getxattr calls (and the man page explicitly mentions this case). In case the attribute grows only a truncated value is returned, when it shrinks, garbage is returned. In both cases Unicode decoding errors can happen. TEST PLAN ctest REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20136 AFFECTED FILES src/xattr_p.h To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams