kossebau created this revision. kossebau added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision.
REVISION SUMMARY The SVG format being based on plain text, storing the SVG in the repository not as .svgz, but .svg, helps both VCS tools (patching, showing diffs) as well as allows some developers to edit the SVG directly in any text editor, not only those which support automatic conversion from/to gzip format. While most artists will continue (and which shall be okay) to use GUI editors like inkscape, which might rewrite the complete structure on saving, using uncompressed format in the repo still allows the occasional direct edit of the text, .e.g. to change a colour, which then is also easily seen in the commit diff. To still keep the svgz format when deployed, a build step is introduced, which uses gzip to create svgz files in the build dir. This conversion can be controlled using the option GZIP_DESKTOPTHEME_SVG (default: ON). With such a build processing in place for SVG files, next to that an optional stripping of the installed SVG files is added, which removes data which is not needed for rendering, e.g. indentation whitespaces or editor-only XML data. This experimental stripping can be controlled using the option STRIP_DESKTOPTHEME_SVG (default: OFF). TEST PLAN Themes are still working (with & without cache removed). REPOSITORY R242 Plasma Framework (Library) BRANCH uncompressedsvginrepo REVISION DETAIL https://phabricator.kde.org/D20166 AFFECTED FILES CMakeLists.txt cmake/Findgzip.cmake cmake/Findsvgcleaner.cmake src/desktoptheme/CMakeLists.txt src/desktoptheme/air/CMakeLists.txt src/desktoptheme/breeze/CMakeLists.txt src/desktoptheme/oxygen/CMakeLists.txt To: kossebau, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns