jgrulich added inline comments.

INLINE COMMENTS

> device.h:241
> +     */
> +    QDBusPendingReply<> reapplyInterface(NMVariantMapMap connection, 
> qulonglong version_id, uint flags);
>      /**

1. const NMVariantMapMap &connection

2. I would maybe pick a different name, because it doesn't reapply interface, 
but it reapplies or updates connection. I would maybe use "reapplyConnection()"

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to