svuorela requested changes to this revision. svuorela added a comment. This revision now requires changes to proceed.
I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name. My systems have several users named "Sune Vuorela" INLINE COMMENTS > kuser.h:412 > + */ > + static QString usernameFromFullname(QString fullname); > /** What happens if multiple users have the same full name? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel, svuorela Cc: svuorela, aacid, kde-frameworks-devel, michaelh, ngraham, bruns
