arrowd added a comment.
In D18296#445829 <https://phabricator.kde.org/D18296#445829>, @dfaure wrote: > Is the makeURL function still used, or should it be removed now? Yep, it is still used in a bunch of other places. INLINE COMMENTS > dfaure wrote in urlinfo.h:39 > const QString & > > And what if it's a URL? At this point this string is pathOrUrl. > const QString & There is `path.chop(match.capturedLength());`, which requires non-const `QString`. > And what if it's a URL? At this point this string is pathOrUrl. Well, `if (QFile::exists(path))` will return false in this case, and `url` would get populated by `url = QUrl::fromUserInput()`. What's wrong with that? > dfaure wrote in urlinfo.h:77 > I'm not sure about AssumeLocalFile, in the context of kde-open. > This is about opening existing files, not creating new files. > So it should be removed. It is not about creating missing files, but reaction to user typos. If I try to open `fiel.txt` instead of a `file.txt`, I want to get a "no such file or directory error message" instead of popping browser trying to open "http://fiel.txt";. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, elvisangelaccio Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
