bruns added a comment.
otherwise, good to go. INLINE COMMENTS > propertyinfotest.cpp:94 > QTest::addColumn<QVariant>("value"); > QTest::addColumn<QString>("expected"); > QTest::addColumn<bool>("maybeLocalized"); Can you add a comment for "expected", telling the expected value uses the English/UnitedState locale? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams