dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
- The description still says "Refactor and cleanup" (note that phabricator doesn't auto-update from the commit log, unless you use arc diff --verbatim, so one often has to copy/paste) - Running the unittests is always good, but they don't cover this code. Please actually use the KCM to test this commit. I would put some nonsense into appSysName first, to make sure I'm testing correctly, then putting back the right value, to make sure it's correct. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns