aacid added a comment.
In D19455#457367 <https://phabricator.kde.org/D19455#457367>, @bcooksley wrote: > This change has broken builds on macOS. > Please see https://binary-factory.kde.org/view/MacOS/job/Kig_Nightly_macos/407/console > > Whilst not documented in the Qt Documentation, the `qmacfunctions.h` header (which is what is included by `#include <QtMac>`) has the following: > > #ifdef Q_OS_OSX > #if QT_DEPRECATED_SINCE(5, 12) > QT_DEPRECATED_X("Use NSApp.dockTile.badgeLabel") Q_MACEXTRAS_EXPORT void setBadgeLabelText(const QString &text); > QT_DEPRECATED_X("Use NSApp.dockTile.badgeLabel") Q_MACEXTRAS_EXPORT QString badgeLabelText(); > > QT_DEPRECATED_X("Use QPixmap::toImage, QImage::toCGImage, and -[NSImage initWithCGImage:size:]") > Q_MACEXTRAS_EXPORT NSImage *toNSImage(const QPixmap &pixmap); > #endif > > Thoughts on the best way forward for macOS builds? i guess add an #undef QT_DISABLE_DEPRECATED_BEFORE inside the #ifdef Q_OS_MACOS of src/kstatusnotifieritem.cpp would get us going? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19455 To: mlaurent, dfaure Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns