kossebau updated this revision to Diff 57481.
kossebau added a comment.

  Add also support for TYPEINFO, merging main logic of ecm_generate_qmltypes
  
  This allows e.g. to replace
  
    install(TARGETS platformcomponentsplugin DESTINATION 
${KDE_INSTALL_QMLDIR}/org/kde/plasma/platformcomponents)
    install(FILES qmldir DESTINATION 
${KDE_INSTALL_QMLDIR}/org/kde/plasma/platformcomponents)
    
    ecm_generate_qmltypes(org.kde.plasma.platformcomponents 2.0 DESTINATION 
${KDE_INSTALL_QMLDIR}/org/kde/plasma/platformcomponents)
  
  and the file qmldir
  
    module org.kde.plasma.platformcomponents
    plugin platformcomponentsplugin
  
  with this code
  
    ecm_install_qmlplugin(platformcomponentsplugin
        IDENTIFIER org.kde.plasma.platformcomponents
        DESTINATION ${KDE_INSTALL_QMLDIR}
        TYPEINFO plugins.qmltypes
        VERSION 2.0
    )
  
  which avoids the need for repeating and ensures consistent data, even more
  when creating new plugins or changing names.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20984?vs=57459&id=57481

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

AFFECTED FILES
  docs/module/ECMInstallQmlModules.rst
  modules/ECMInstallQmlModules.cmake

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

Reply via email to